Open
Conversation
@gfarb had opened a PR with these changes a long time ago.
There was a problem hiding this comment.
Pull Request Overview
This PR replaces an earlier submission by updating variable and secret names to distinguish production credentials from development ones. Key changes include:
- Renaming secrets in GitHub Actions workflows to use production identifiers.
- Updating documentation to reflect the renamed variables.
- Modifying the issue branch creation workflow to align with these naming changes.
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/push-to-main-handler.yml | Updated secret names and deployment commands for production use. |
| docs/Getting Started.md | Adjusted documentation to reference production secret names. |
| .github/workflows/issue-branch-creation-handler.yml | Revised secret names for production in the branch creation workflow. |
Files not reviewed (1)
- scripts/sandbox_auth: Language not supported
Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more
| run: | | ||
| echo "${SALESFORCE_TEMPLATE_JWT_SECRET_KEY}" > template-server.key | ||
| sudo npx sf org login jwt --client-id ${{ secrets.SALESFORCE_TEMPLATE_CONSUMER_KEY }} --jwt-key-file template-server.key --username ${{ secrets.SALESFORCE_TEMPLATE_USERNAME}} --alias Template --instance-url https://test.salesforce.com | ||
| sudo npx sf org login jwt --client-id ${{ secrets.SALESFORCE_TEMPLATE_CLIENT_ID }} --jwt-key-file server.key --username ${{ secrets.SALESFORCE_TEMPLATE_USERNAME}} --alias Template --instance-url https://test.salesforce.com |
There was a problem hiding this comment.
The key file referenced for JWT authentication does not match the file created in a previous step ('template-server.key'); update the command to use 'template-server.key'.
Suggested change
| sudo npx sf org login jwt --client-id ${{ secrets.SALESFORCE_TEMPLATE_CLIENT_ID }} --jwt-key-file server.key --username ${{ secrets.SALESFORCE_TEMPLATE_USERNAME}} --alias Template --instance-url https://test.salesforce.com | |
| sudo npx sf org login jwt --client-id ${{ secrets.SALESFORCE_TEMPLATE_CLIENT_ID }} --jwt-key-file template-server.key --username ${{ secrets.SALESFORCE_TEMPLATE_USERNAME}} --alias Template --instance-url https://test.salesforce.com |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@gfarb had opened a PR with these changes a long time ago. I couldn't rebase his cause it's from his private repo, so this replaces it.